Perl::Critic::Policy::BuiltinFunctions::ProhibitStringySplit - Write split /-/, $string instead of split '-', $string.
Perl::Critic::Policy::BuiltinFunctions::ProhibitStringySplit - Write
split /-/, $string instead of
split '-', $string.
This Policy is part of the core Perl::Critic distribution.
split function always interprets the PATTERN argument as a regular expression, even if you specify it as a string. This causes much confusion if the string contains regex metacharacters. So for clarity, always express the PATTERN argument as a regex.
$string = 'Fred|Barney'; @names = split '|', $string; #not ok, is ('F', 'r', 'e', 'd', '|', 'B', 'a' ...) @names = split m/[|]/, $string; #ok, is ('Fred', Barney')
When the PATTERN is a single space the
split function has special behavior, so Perl::Critic forgives that usage. See
"perldoc -f split" for more information.
This Policy is not configurable except for the standard options.
Jeffrey Ryan Thalhammer <email@example.com>
Copyright (c) 2005-2011 Imaginative Software Systems. All rights reserved.
This program is free software; you can redistribute it and/or modify it under the same terms as Perl itself. The full text of this license can be found in the LICENSE file included with this module.